On 8/4/2019 9:34 PM, Andreas Rheinhardt wrote: > Timo Rothenpieler: >> On 04.08.2019 23:52, Andreas Rheinhardt wrote: >>> It uses a nonstandard inclusion guard. >> >> Is there any problem with just fixing the inclusion guard instead? >> I forgot that this exists, but the inclusion guard in it looked fairly >> standard to me. >> Feel free to just fix it. >> > The standard inclusion guard for this file should be > COMPAT_CUDA_CUDA_RUNTIME_H without AV_, as this file isn't in any of > the libav*/ paths (at least that is what the source test expects). > Given that this header is designed to fulfill FFmpeg's needs and given > that dynlink_loader.h also uses an AV_ prefix (and is therefore marked > as an exception in the source test ref file), I thought that it is > intended to use the AV_ prefix so that it needs to be marked as an > exception. But if this is not so, then said prefix can of course be > removed. I don't know which of the two ways should be choosen. > > - Andreas
Remove the AV_ prefix. It's unnecessary and was probably added by mistake. And while at it, you can do the same with dynlink_loader.h _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
