> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Nicolas George > Sent: Thursday, August 01, 2019 5:10 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] dnn: rename function from > dnn_execute_layer_pad to avfilter_dnn_execute_layer_pad > > Paul B Mahol (12019-08-01): > > I do not like this. > > I agree. The av namespace is for public functions.
sorry that the test uses the internal function at unit test level. I'll send out a patch to revert it since it is not allowed, I'll then consider a better solution for the test. My intention was to verify the dnn layers separately and directly, so one test for each layer was my choice. And so I can add more dnn layers and its unit test one by one, and then add dnn generic filters at proper time. I now know it is not the right choice and I'll plan to add filter test into FATE after a meaningful filter is enabled. > > Regards, > > -- > Nicolas George _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
