On Wed, Jul 17, 2019 at 10:53:08AM -0400, Vittorio Giovara wrote: > On Tue, Jul 16, 2019 at 10:29 PM Limin Wang <lance.lmw...@gmail.com> wrote: > > > On Tue, Jul 16, 2019 at 09:36:32PM -0400, Rick Kern wrote: > > > Testing for the new transfer functions when compiling for OSX 10.12 > > reports > > > the color settings as "yuv420p(tv, bt2020nc/bt2020/reserved)" in ffprobe. > > > Is "reserved" (0) the expected default when the transfer function isn't > > > supported? > > mac 10.13 support: > > kCVImageBufferTransferFunction_SMPTE_ST_2084_PQ > > kCVImageBufferTransferFunction_ITU_R_2100_HLG > > > > OSX 10.14 support: > > kCVImageBufferTransferFunction_Linear > > > > For 10.12, the HAVE_* macros should be detected as 0 if correct. > > > > 0 is a reserved value in the color specification and should be avoided if > possible. > Would it be possible to fallback on 2 (unknown) when these macros are not > found?
OSX have defined it as string and no such string map to 2(unknown), so if we failed to get the map string, it'll set to NULL and we'll not set the interface. Or we should check the result and failed the init to avoid it. but it's not related to the patch, without it, you should get the same result. > -- > Vittorio > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
