>> -        !ost->copy_initial_nonkeyframes)
>> +        !ost->copy_initial_nonkeyframes) {
>> +        av_log(NULL, AV_LOG_DEBUG, "skipping initial
>> non-keyframe\n"); return;  
> 
> Incorrect indentation.

It's actually the same indentation as in other places in the same file,
what would be the correct way then?

> I suggest this message should be at INFO level, but appear only once.

I'm fine with INFO level. Repeated messages get supressed anyways, does
that suffice?

> I believe ffprobe also suffers from such files and never displays
> anyhing with -show_frames. In fact, does ffprobe perhaps always begin
> from, or at least wait for, the first keyframe?

Cannot really comment on that. For me it happens when stream copying
from v4l2, since the keyframe flag is not being set there, Probing
works just fine.

Attachment: pgpeXjj2FFihR.pgp
Description: OpenPGP digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to