On 29/05/2019 17:12, James Almer wrote:
>> +end:
>> + if (cfg)
>> + rav1e_config_unref(cfg);
>> +
>> + if (ret)
>> + librav1e_encode_close(avctx);
>
> Use the FF_CODEC_CAP_INIT_CLEANUP flag in AVCodec.caps_internal instead.
> It will call AVCodec.close() on AVCodec.init() failure.
OK.
>> + .pix_fmts = (const enum AVPixelFormat[]) {
>> + AV_PIX_FMT_YUV420P,
>> + AV_PIX_FMT_YUV420P10,
>> + AV_PIX_FMT_YUV420P12,
>> + AV_PIX_FMT_YUV422P,
>> + AV_PIX_FMT_YUV422P10,
>> + AV_PIX_FMT_YUV422P12,
>> + AV_PIX_FMT_YUV444P,
>> + AV_PIX_FMT_YUV444P10,
>> + AV_PIX_FMT_YUV444P12,
>> + AV_PIX_FMT_GRAY8,
>> + AV_PIX_FMT_GRAY10,
>> + AV_PIX_FMT_GRAY12,
>> + AV_PIX_FMT_NONE
>
> Nit: Split this off, like libx26* do.
OK.
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
