To clarify, do you mean we should merge this now or wait for the second patch, which fixes the root cause?
> On May 23, 2019, at 10:12 AM, Derek Buitenhuis <derek.buitenh...@gmail.com> > wrote: > >> On 22/05/2019 18:55, Darren Mo wrote: >> Good question. The subtitle would be discarded if it overlaps an edit >> boundary. >> >> The root cause is the MOV demuxer currently marks boundary packets for >> discard. However, due to subtitle frames not being discarded (fixed by this >> patch), the root cause is hidden. A potential fix for the root cause would >> be to handle boundary packets by changing their timestamps to fit the edit >> boundary. (That would be a separate patch though.) > > As a start, this patch seems reasonable then... > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
