> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of James Almer > Sent: Friday, May 17, 2019 5:30 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx) > > On 5/16/2019 6:06 PM, Lynne wrote: > > May 16, 2019, 8:43 PM by geo...@nsup.org: > > > >> Lynne (12019-05-16): > >> > >>> I'm not, I still want the 2 checks. > >>> > >> > >> Arguments please. As I explained, the first check is harmful to > >> applications because it hides bug. > >> > > > > Nevermind, its not really possible to give av_tx_uninit() a NULL double > pointer so > > whatever. Can the author just push a patch already? > > I did it just now, but as the author and maintainer of the code in > question you're the most adequate person to review and push patches for it. After reading the discussion, I agree to use v1 to just crash if null pointer passed in and thanks James for approve and push the patch. And thank you all for the active discussion:)
Ruiling > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
