> -----Original Message----- > From: Pedro Arthur [mailto:bygran...@gmail.com] > Sent: Tuesday, April 30, 2019 9:33 AM > To: Guo, Yejun <yejun....@intel.com> > Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data type > support for dnn model input > > Em seg, 29 de abr de 2019 às 22:21, Guo, Yejun <yejun....@intel.com> > escreveu: > > > > > > > > > -----Original Message----- > > > From: Pedro Arthur [mailto:bygran...@gmail.com] > > > Sent: Tuesday, April 30, 2019 1:47 AM > > > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > > > Cc: Guo, Yejun <yejun....@intel.com> > > > Subject: Re: [FFmpeg-devel] [PATCH V2 7/7] libavfilter/dnn: add more data > type > > > support for dnn model input > > > > > > Em qua, 24 de abr de 2019 às 23:15, Guo, Yejun <yejun....@intel.com> > > > escreveu: > > > > > > > > currently, only float is supported as model input, actually, there > > > > are other data types, this patch adds uint8. > > > > > > > > Signed-off-by: Guo, Yejun <yejun....@intel.com> > > > > > > > > > LGTM. > > > > > > I think it would be valuable to add a few tests covering the features > > > added by this patch series. > > > > thanks, good point. Do you mean FATE? Is there any previous test for DNN > module that I can refer to? thanks. I'll investigate it after my holiday, I'm > starting vacation today. > > Yes, I mean FATE, unfortunately there isn't any tests for DNN atm.
I plan to first add unit tests in FATE for DNN module, since the DNN interfaces is not exported as ffmpeg APIs. I'll add tests/fate/dnn.mak, and also a new folder at tests/dnn. There will be .c files under tests/dnn, and each .c file contains main() function to verify one feature of dnn module. It will be a self-contained test, no source samples nor reference data is required. In the future, we can add tests/fate/dnn-filters.mak to verify deep learning based filters with source samples and reference data. > > Have a nice vacation! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
