Στις Παρ, 3 Μαΐ 2019 στις 11:36 π.μ., ο/η Michael Niedermayer <mich...@niedermayer.cc> έγραψε: > > this will break timestamp handling > not sure what you are trying to do exactly but the way its done is wrong. > There is alot of code that depends on the timestamps from the demuxer > not being mangled like this. > > also its the wrong place, timestamp discontinuities are not a thing limited > to mpegts. And there are already layers of attempts to try to do what this > seems to try. Simple rule, if you dont need to allocate memory proportional > to duration in some cases then your code is wrong. Also if you dont intercept > seeks chapters and so on, again the code would be incomplete. > > If you want a specific testcase that this breaks. It breaks tbr values > amongth other things for > tickets/2186/multiple_programs.ts > > thanks
As I mentioned in ticket http://trac.ffmpeg.org/ticket/7876 this is not my code, I just adapted it for current git. It is also very old code (back from 2012), probably it fitted OK back then. This code fixes this specific issue reported in the ticket. If it breaks other things, then of course it can't be commited. Still there is a need for a fix for the reported issue in the ticket, as it is you can't transcode with -copyts above 26,5 hours, it fails after that. > > [...] > > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If you fake or manipulate statistics in a paper in physics you will never > get a job again. > If you fake or manipulate statistics in a paper in medicin you will get > a job for life at the pharma industry. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
