On Thu, Apr 18, 2019 at 05:12:14PM -0700, Dan Sanders via ffmpeg-devel wrote: > Fixes: UBSan runtime error > Found-by: Clusterfuzz > --- > libavformat/apetag.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/apetag.c b/libavformat/apetag.c > index cdc602e1a9..2991f57d5d 100644 > --- a/libavformat/apetag.c > +++ b/libavformat/apetag.c > @@ -29,10 +29,10 @@ > #include "apetag.h" > #include "internal.h" > > -#define APE_TAG_FLAG_CONTAINS_HEADER (1 << 31) > -#define APE_TAG_FLAG_LACKS_FOOTER (1 << 30) > -#define APE_TAG_FLAG_IS_HEADER (1 << 29) > -#define APE_TAG_FLAG_IS_BINARY (1 << 1) > +#define APE_TAG_FLAG_CONTAINS_HEADER (1U << 31) > +#define APE_TAG_FLAG_LACKS_FOOTER (1U << 30) > +#define APE_TAG_FLAG_IS_HEADER (1U << 29) > +#define APE_TAG_FLAG_IS_BINARY (1U << 1)
LGTM (both with all changed as in the patch or just one changed) whoever pushes please fix the Author/FROM (not pushing myself as theres a discussion about changing only 1 #define) thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
