Hi James, > On Apr 9, 2019, at 4:09 PM, James Almer <jamr...@gmail.com> wrote: > >> […] > > Ok so, the only fields you need from the sps are constraint_set_flags, > frame_mbs_only_flag, bit_depth_luma, profile_idc, level_idc and sar, > meaning you don't even need to parse the sps until the very end (sar is > the furthest value, and right at the beginning of vui_parameters). > I'd very much prefer if we can avoid making > ff_h264_decode_seq_parameter_set() avpriv and with it H264ParamSets part > of the ABI, so i think it's worth copying the required bitstream parsing > code at least until the beginning of vui_parameters. It was done for > hevc and av1, so it can be done for h264 as well.
Since vui parsing is needed, that would be the entire "ff_h264_decode_seq_parameter_set()” function. I disagree with the copying. I also disagree with the copying for AVC1 and HEVC btw. — Baptiste _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
