2019-04-08 22:37 GMT+02:00, Shivam Goyal <shi...@iitk.ac.in>:
> Updated patch for ticket #3720 .
>
> I have tried to improve the patch as suggested.

Please fix the commit message as suggested by Lauri
and please make above (first) line part of the commit
message.

The first avio_seek() should be a skip, the header
function always starts reading the file from the top.

> +    offset = (((avio_r8(ic) + rot)&0xff)<<24) |
> +                (((avio_r8(ic) + rot)&0xff)<<16) |
> +                (((avio_r8(ic) + rot)&0xff)<<8) |
> +                (((avio_r8(ic) + rot)&0xff)) + 0x200000;

offset = ((avio_r8(ic) + rot & 0xff) << 24 |
          (avio_r8(ic) + rot & 0xff) << 16...

assuming this produces no warnings.
There is no 12-char indentation, only vertical alignment.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to