2019-03-20 23:20 GMT+01:00, Aidan R <aidan...@hotmail.co.uk>: > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Michael > Niedermayer <mich...@niedermayer.cc> > Sent: 20 March 2019 19:08 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/westwood_aud: Adds PCM > format demux. > >> fails probetest: >> >> >> tools/probetest 256 4096 >> testing size=1 >> testing size=2 >> testing size=4 >> testing size=8 >> testing size=16 >> testing size=32 >> Failure of wsaud probing code with score=50 type=3 p=2D8 size=32 >> testing size=64 >> testing size=128 >> testing size=256 >> testing size=512 >> testing size=1024 >> testing size=2048 > > What is the appropriate way to resolve this if the format doesn't > provide enough information to identify it uniquely? Return > AVPROBE_SCORE_RETRY when we know we can't identify > a file with a high enough confidence?
Another possibility would be to commit the patch without the change to the probe function (you can still force the format) and then think about the probe function independently. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
