On Mon, Mar 11, 2019 at 2:55 AM Tomas Härdin <tjop...@acc.umu.se> wrote:
> sön 2019-03-10 klockan 19:03 -0700 skrev mindm...@gmail.com: > > > From: Mark Reid <mindm...@gmail.com> > > > > This patch restores the ability to add user comments for the opatom_mxf > muxer. > > The ability seems to have been disabled in d9726893f31. > > Seems the intent was to only disable them for D-10, so this is probably > fine. You should change this too: > > IRT D-10 does not allow user comments. The default is thus to write > them for mxf but not for mxf_d10 > > to > > IRT D-10 does not allow user comments. The default is thus to write > them for mxf and mxf_opatom but not for mxf_d10 > > oops missed the line. > The comment from Michael in d9726893f31 about comments causing problems > for "users" has me worried. We *need* functional tests for stuff like > that.. > > I'll try and add a fate test with the next version of the patch. Thanks for the review. > /Tomas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
