On 2/19/19, Adam Sampson <a...@offog.org> wrote: > When a JACOsub subtitle has two timestamps, they represent its start and > end times (http://unicorn.us.com/jacosub/jscripts.html#l_times); the > duration is the difference between the two, not the sum of the two. > > The subtitle end times in the FATE test for this were wrong as a result; > fix them too. (This test is based on JACOsub's demo.txt, and the end > time computed for the last line using @ now matches what the comments > there say it should be.) > > Also tested in practice using MPV, a LaserDisc, and some authentic 1993 > JACOsub files. > > Signed-off-by: Adam Sampson <a...@offog.org> > --- > v2: update the test data too (thanks, Carl Eugen!) > > libavformat/jacosubdec.c | 2 +- > tests/ref/fate/sub-jacosub | 22 +++++++++++----------- > 2 files changed, 12 insertions(+), 12 deletions(-) >
LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
