On Fri, Feb 01, 2019 at 08:38:12AM +0000, Lin, Decai wrote: > > > > -----Original Message----- > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > myp...@gmail.com > > Sent: 2019年2月1日 15:14 > > To: FFmpeg development discussions and patches > > <ffmpeg-devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: no need check ref > > list1 for P slices. > > > > On Fri, Feb 1, 2019 at 1:28 PM Lin, Decai <decai....@intel.com> wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > > > > Behalf Of Michael Niedermayer > > > > Sent: 2019年2月1日 1:12 > > > > To: FFmpeg development discussions and patches > > > > <ffmpeg-devel@ffmpeg.org> > > > > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: no need > > > > check ref > > > > list1 for P slices. > > > > > > > > On Thu, Jan 31, 2019 at 03:36:56PM +0800, Decai Lin wrote: > > > > > This is robust for some corner case there is incorrect list1 count > > > > > in pps header, but it's a P slice and can be decoded well. > > > > > > > > please provide a sample h264 video that needs this > > > > > > > > > > Attached the test clip for this patch. > > > > > > > I think the better way is to add a new fate test case with the test clip for > > h264dec, isn't it? > > Yes, I can file another patch for the related fate test case.
fate tests covering previously uncovered cases is always a good idea thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
