On Fri, Feb 01, 2019 at 05:50:37PM +0800, myp...@gmail.com wrote: [...] > > Ok, makes sense. Would you mind updating the comment to something like: > > > > /* Note: WEIGHT_LUT_SIZE must be larger than max_meaningful_diff > > * (log(255)*max(h)^2, which is approximately 500000 with the current > > * maximum sigma of 30). The current value is arbitrary and could be > > * tweaked or defined dynamically. */ > > #define WEIGHT_LUT_SIZE 800000 > > > > I will test your patch tonight (let's say in about 10 hours given my > > current timezone) and apply if everything works fine. > > > it's OK, and I think you can change 800000 to 500000 at the same time > if the patch is Ok. Tks
I did change it to 500000, added a comment, updated the description, and pushed. I also made the dynamic change you suggested earlier on the weight LUT. Thanks for the patch, -- Clément B.
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
