On Wed, Jan 16, 2019 at 11:54:42 -0800, Mohammad Izadi wrote:
> Subject: Support HDR dynamic metdata (HDR10+) in HEVC decoder.
^ Nit no. 1: metadata
Nit no. 2: Preferred format:
avcodec/hevcdec: add support for HDR dynamic metadata (HDR10+)
> + if (((rows < 2) && (rows > 25)) || ((cols < 2) && (cols > 25))) {
Have you confused something? How can rows be smaller than 2 and larger
than 25 at the same time?
This should probably be
if ((rows < 2) || (rows > 25) || (cols < 2) || (cols > 25)) {
> + av_log(logctx, AV_LOG_ERROR, "num_rows=%d, num_cols=%d, they
> must [2, 25] for targeted_system_display_actual_peak_luminance\n", rows,
> cols);
> + if (((rows < 2) && (rows > 25)) || ((cols < 2) && (cols > 25))) {
> + av_log(logctx, AV_LOG_ERROR, "num_rows=%d, num_cols=%d, they
> must be in [2, 25] for mastering_display_actual_peak_luminance\n", rows,
> cols);
Same here. And the wording is slightly different, "be in" is missing in
the first one.
> +typedef struct HEVCSEIDynamicHDRPlus{
" {"
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
