On Tue, Jan 15, 2019 at 12:18:44AM +0100, Hendrik Leppkes wrote: > On Mon, Jan 14, 2019 at 9:48 PM Peter Ross <pr...@xvid.org> wrote:
> > diff --git a/libavcodec/vp3dsp.h b/libavcodec/vp3dsp.h
> > index f55a7f834f..30a76100d9 100644
> > --- a/libavcodec/vp3dsp.h
> > +++ b/libavcodec/vp3dsp.h
> > @@ -43,8 +43,13 @@ typedef struct VP3DSPContext {
> > void (*idct_dc_add)(uint8_t *dest, ptrdiff_t stride, int16_t *block);
> > void (*v_loop_filter)(uint8_t *src, ptrdiff_t stride, int
> > *bounding_values);
> > void (*h_loop_filter)(uint8_t *src, ptrdiff_t stride, int
> > *bounding_values);
> > + void (*v_loop_filter_12)(uint8_t *src, ptrdiff_t stride, int
> > *bounding_values);
> > + void (*h_loop_filter_12)(uint8_t *src, ptrdiff_t stride, int
> > *bounding_values);
> > } VP3DSPContext;
> >
> > +void ff_vp3dsp_v_loop_filter_12(uint8_t *first_pixel, ptrdiff_t stride,
> > int *bounding_values);
> > +void ff_vp3dsp_h_loop_filter_12(uint8_t *first_pixel, ptrdiff_t stride,
> > int *bounding_values);
> > +
>
> It seems weird to have DSP member methods for the 12 pixel loop
> filter, but then never assign or use them. Is that a remnant from an
> earlier approach?
Yeah. I will remove those unused context function pointers.
Thanks for noticing this.
-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
