> On 2 Jan 2019, at 18:38, Nicolas George <geo...@nsup.org> wrote: > > Oliver Collyer (2019-01-02): >> Can you clarify what you mean by "static variables are unacceptable". >> They're all over the place in ffmpeg (random example >> https://github.com/FFmpeg/FFmpeg/blob/a0ac49e38ee1d1011c394d7be67d0f08b2281526/libavcodec/ffjni.c >> >> <https://github.com/FFmpeg/FFmpeg/blob/a0ac49e38ee1d1011c394d7be67d0f08b2281526/libavcodec/ffjni.c>)... >> what am I missing? > > The JNI stuff is hardly an example of good practice, we are stuck with > java's awful design. > > For the rest, they are not static variables, they are static constants. > > There are a few cases >
Ok thanks for the clarification about the approach taken for static variable usage and memory freeing in the ffmpeg project Nicolas, that is useful to know. So I could re-write the patch to not use static variables, and I'm perfectly happy to do so, but there is no point, right? Regards Oliver > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
