> -----Original Message----- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Moritz Barsnick > Sent: Thursday, December 27, 2018 8:47 PM > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH V2] avfilter: Add tonemap vaapi filter > > On Thu, Dec 27, 2018 at 16:55:17 +0800, Zachary Zhou wrote: > > +typedef enum { > > + HDR_VAAPI_H2H, > > + HDR_VAAPI_H2S, > > +} HDRType; > > > +static const AVOption tonemap_vaapi_options[] = { > > + { "type", "hdr type", OFFSET(hdr_type), AV_OPT_TYPE_INT, > > { .i64 > = HDR_VAAPI_H2H }, 0, 2, FLAGS, "type" }, > > + { "h2h", "vaapi P010 to RGB10", 0, AV_OPT_TYPE_CONST, > {.i64=HDR_VAAPI_H2H}, INT_MIN, INT_MAX, FLAGS, "type" }, > > + { "h2s", "vaapi P010 to RGB8", 0, AV_OPT_TYPE_CONST, > > +{.i64=HDR_VAAPI_H2S}, INT_MIN, INT_MAX, FLAGS, "type" }, > > Is it intentional that specifying 2 is possible, but not documented? (I see > there's code handling it as switch/case/default or > if/else_if/else.) > > By the way, did someone mention a required change to doc/filters.texi?
Thanks Moritz for the comments, I got it. I am adding document to doc/filters.texi, I will resend the patch soon. -Zach > > Moritz > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
