2018-12-12 23:44 GMT+01:00, Paul B Mahol <one...@gmail.com>:
> On 12/12/18, Carl Eugen Hoyos <ceffm...@gmail.com> wrote:
>> 2018-12-12 23:30 GMT+01:00, Paul B Mahol <one...@gmail.com>:
>>> On 12/12/18, Carl Eugen Hoyos <ceffm...@gmail.com> wrote:
>>>> Hi!
>>>>
>>>> Attached patch fixes ticket #4553 for me.
>>>>
>>>> Please comment, Carl Eugen
>>>
>>> I do not like what you did to G729Context.
>>
>>> Please rewrite patch.
>>> Move relevant parts into G729ChannelContext chan[2];
>>
>> Which part of the context does not need to be duplicated?
>
> AudioDSPContext adsp;

Looks like 24 bytes. (Or twelve?)
I would really prefer not to make this patch more
complicated to save 24 bytes on the heap that may get lost
on the additional allocation.

Carl Eugen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to