>On 11/28/18, 8:19 PM, "Moritz Barsnick" <barsn...@gmx.net> wrote:
>
>On Wed, Nov 28, 2018 at 20:10:11 +0530, Karthick J wrote:
>> + // If url is an empty string("") don't write sidx atom.
>> + if (s->url[0] == '\0')
>> + return res;
>
>Probably clearer if you return 0, as res hasn't been assigned anything
>up to this point, except its initial 0.
Makes sense. Sent PATCH v2 with this change.
Regards,
Karthick
>
>Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
