On 31/10/18 00:07, Ronak Patel wrote: > >> On Oct 27, 2018, at 5:25 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >> >> 2018-10-27 20:50 GMT+02:00, Mark Thompson <s...@jkqxz.net>: >>> This reverts commit 6dbb64fdccafe846aaec75d3784f7ad49d8af5df. >>> >>> The additional braces cause build errors with Linux headers earlier >>> than 4.5 because the first element of the structure was not originally >>> a union. >> >>> Not sure what compiler was warning about these, but it's definitely >>> incorrect for it to do so. >> >> Must have been NDK clang. > > This fix isn’t enough for this. The references to the variables in the union > fail to compile. This doesn’t fix that.
I tried both before and after the change at 4.5: <https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/videodev2.h#L1593>, <https://elixir.bootlin.com/linux/v4.4.162/source/include/uapi/linux/videodev2.h#L1481>. What headers do you have and what are the errors in that version? - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
