> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Moritz Barsnick > Sent: Tuesday, October 23, 2018 4:55 PM > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter/vaapi: enable vaapi rotation > feature via call Intel iHD driver > > On Tue, Oct 23, 2018 at 15:52:40 +0800, Zachary Zhou wrote: > > It supports clockwise rotation by 0/90/180/270 degrees defined in > > va/va_vpp.h, tested following command line on SKL platform > > Since these angles of rotation are called "transpose" in ffmpeg's other > filters > (transpose, transpose_npp), shouldn't that be the name chosen for this > functionality? > > It could then also use similar options. > > Just wondering.
Not sure vaapi can expose more angles or not. So I prefer to keep the name as "rotation" which is aligned with vaapi. But using similar options/suboptions should be a good idea. > > The filter(s) could also use some documentation (doc/filters.texi), but the > existing vaapi ones don't have any either, so *sigh*. > > Cheers, > Moritz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
