Paul B Mahol (2018-09-30):
> > For consistency within a single function, an assert is the correct
> > choice.
> No, it is not. Asserts do not add any consistency.

Asserts do not add consistency indeed. Their purpose is to check
consistency, which is exactly what needs testing here: the consistency
between the preliminary test and the later switch statement.

If you want to argue for AVERROR_BUG, please give arguments.

Regards,

-- 
  Nicolas George

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to