On Thu, Sep 27, 2018 at 4:09 AM Michael Niedermayer <mich...@niedermayer.cc> wrote:
> On Wed, Sep 26, 2018 at 06:03:19PM +0800, Jun Zhao wrote: > > For HEVC/MPEG4, we also need video_delay from the decoder, when decoding > > some HEVC/MPEG4 clips, got numerous log like: > > "video_delay is larger in decoder than demuxer", similar ticket: #3711 > > for mpeg4 this looks incorrect. > > What your patch does is simply override the "demuxer side" but the patch > never explains why this would be the correct solution or why the demuxer > side gets the value wrong > > Obviously if something (like the "demuxer side") gets a value wrong the > obvious solution is to fix that. For H264 determining the delay is rather > hard in some corner cases (as a result of the field that would signal the > delay being optional and not available in all streams) > > So please either fix the code that is responsible for this being set > wrong in mpeg4 or explain why we should hack around it instead of > fixing it. > > thx > > So I need to dig in and root cause, I agree. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
