On Sat, 22 Sep 2018, Michael Niedermayer wrote:

On Fri, Sep 21, 2018 at 12:11:59AM +0200, Marton Balint wrote:
These are based on the very similar UDP and RTP protocol functions.

Signed-off-by: Marton Balint <c...@passwd.hu>
[...]

Thanks, I will resubmit the patch series with some extra docs.

[...]

+
+/**
+ * Frees the internal fields of an IPSourceFilters structure.
+ */
+void ff_ip_free_filters(IPSourceFilters *filters);

IPSourceFilters is "allocated" by the user ?
this may cause an issue if its used in libavdevice in the future
just mentioning so this relation is considered

I think I'll just rename this to ff_ip_reset_filters because *_free might give the wrong impression that it frees the structure itself.

As for the potential issues, this is internal API, so it can be changed anytime, but TBH I don't think this will be used in libavdevice anytime soon...

Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to