On Sun, 2 Sep 2018, Gyan Doshi wrote:

On 01-09-2018 10:25 PM, Marton Balint wrote:

In the descriptive text write "seeking" instead of jumping.

@item -nodisp
Disable graphical display.
@item -noborder
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index 368e262123..83eef17797 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -319,6 +319,7 @@ static int video_disable;
static int subtitle_disable;
static const char* wanted_stream_spec[AVMEDIA_TYPE_NB] = {0};
static int seek_by_bytes = -1;
+static float jump_interval = 0;

why not make this = 10.0 by default? And change the code below accordingly.

Changed 'jump' to 'seek' throughout.

Change the option name to seek_interval then, -seek alone seems a bit confusing to me because it might mean to do initial seek in the input before playing the file.


Haven't changed code much, kept basic protection against invalid input (val < 0)

I don't think the guards are necessary, it might make sense for somebody to reverse the meaning of left and right keys, therefore use a negative value.

Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to