James Almer (2018-08-24): > Invalid input (say, a packet reporting a frame size of the equivalent of > 1ms) would assert before and after this patch. Do you consider an assert > that triggers on invalid input to be wrong? I thought that was the > entire point of one...
Assert failures cause an immediate exit and core dump. If a crafted input can trigger a failure and crash the application, that is a serious problem. Asserts are there to catch bugs. > If you prefer i can remove the entire assert altogether. Or maybe > replace it with a normal check that returns an error instead. If you just remove the assert, then the invalid value is passed to the rest of the code. You know better than me how it will react to it. Regards, -- Nicolas George
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
