-------- Forwarded Message --------
Subject: Re: [FFmpeg-devel] [PATCH v2][GSOC] avfilter: added
colorconstancy
Date: Sun, 15 Jul 2018 20:51:09 +0200
From: Mina <minas.go...@gmail.com>
To: Gyan Doshi <gyando...@gmail.com>
On 07/15/2018 07:16 AM, Gyan Doshi wrote:
On 15-07-2018 07:50 AM, Mina wrote:
First, thanks for your feedback.
+A variation color constancy that estimates scene illumination via
grey edge algorithm
+and corrects the scene colors accordingly.
"A variation color constancy filter which estimates ..."
Okay will be changed to "A color constancy variation filter which estimates"
Maybe add a link to the algo paper in the next line:
"Grey Edge algorithm: http://...";
The link I have is to a research paper so I didn't think a non-developer
user would benefit from it but will add it.
> +The order of diffrentation to be applied on the scene. Must be
chosen in the range
diffrentation -> differentiation
Changed.
> +chosen in the range [0,1024.0] and default value = 1. Sigma can't
be set to 0
> +if @var{difford} is greater than 1.
but for set_gauss, you say
> Sigma can be zero only at difford = 0
and test during config
> av_assert0(sigma || !s->difford);
Please correct the docs. Also prefer that you log an informational
error and return AVERROR(EINVAL) instead of an assert.
Sure, will do.
Thanks,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
