On Thu, Jul 12, 2018 at 11:29 PM, Moritz Barsnick <barsn...@gmx.net> wrote:
> > +#define LANCZOS_RESOLUTION 256 > > > + av_log(ctx, AV_LOG_INFO, "Using camera %s\n", > lensfun->camera->Model); > [...] > > + av_log(ctx, AV_LOG_FATAL, "Failed to find camera in lensfun > database\n"); > > If you're logging the model on success, you might as well also log it > on failure. > > > + av_log(ctx, AV_LOG_INFO, "Using lens %s\n", > lensfun->lens->Model); > [...] > > + av_log(ctx, AV_LOG_FATAL, "Failed to find lens in lensfun > database\n"); > > Same here. Actually, it is impossible to log the model because on failure, the pointer to camera/lens is NULL, which is where such info is originally derived from. The main reason I log the camera/lens model is because when querying the lensfun API with the user string for camera/lens model, lensfun returns a list, sorted by best match. Since it is possible for users to supply an incomplete string of the camera/lens model I figure it would be helpful to log the camera/lens model chosen by the filter (it just picks the best match, first in the list returned from the lensfun API). Everything else makes sense though. I will send another patch once I'm done with the fixes. Thanks, Stephen Seo _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
