> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Danil Iashchenko
> Sent: Thursday, July 12, 2018 7:02 AM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Danil Iashchenko <danyasche...@gmail.com>
> Subject: [FFmpeg-devel] [PATCH] lavfi/convolution_opencl: implement
> CL_FAIL_ON_ERR macro
Hi Danil,

The patch looks good, But I think it would be more proper to use a title like 
"switch to use CL_FAIL_ON_ERROR " or "use CL_FAIL_ON_ERROR for error handling".

Ruiling
> 
> ---
>  libavfilter/vf_convolution_opencl.c | 46 
> +++++++++----------------------------
>  1 file changed, 11 insertions(+), 35 deletions(-)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to