On Tue, Jun 26, 2018 at 09:28:01AM -0700, Jacob Trimble wrote:
> On Mon, Jun 25, 2018 at 5:30 PM Michael Niedermayer
> <mich...@niedermayer.cc> wrote:
> >
> > On Fri, Jun 01, 2018 at 12:51:48PM -0700, Jacob Trimble wrote:
> > > Signed-off-by: Jacob Trimble <modma...@google.com>
> > > ---
> > > libavutil/Makefile | 1 +
> > > libavutil/encryption_info.h | 2 +-
> > > libavutil/tests/.gitignore | 2 +
> > > libavutil/tests/encryption_info.c | 176 ++++++++++++++++++++++++++++++
> > > tests/fate/libavutil.mak | 4 +
> > > tests/ref/fate/encryption-info | 0
> > > 6 files changed, 184 insertions(+), 1 deletion(-)
> > > create mode 100644 libavutil/tests/encryption_info.c
> > > create mode 100644 tests/ref/fate/encryption-info
> > >
> > > diff --git a/libavutil/Makefile b/libavutil/Makefile
> > > index d0632f16a6..9ed24cfc82 100644
> > > --- a/libavutil/Makefile
> > > +++ b/libavutil/Makefile
> > > @@ -200,6 +200,7 @@ TESTPROGS = adler32
> > > \
> > > des \
> > > dict \
> > > display \
> > > + encryption_info \
> > > error \
> > > eval \
> > > file \
> >
> > > diff --git a/libavutil/encryption_info.h b/libavutil/encryption_info.h
> > > index 9140968fde..8fe7ebfe43 100644
> > > --- a/libavutil/encryption_info.h
> > > +++ b/libavutil/encryption_info.h
> > > @@ -129,7 +129,7 @@ typedef struct AVEncryptionInitInfo {
> > > *
> > > * @param subsample_count The number of subsamples.
> > > * @param key_id_size The number of bytes in the key ID, should be 16.
> > > - * @param key_id_size The number of bytes in the IV, should be 16.
> > > + * @param iv_size The number of bytes in the IV, should be 16.
> > > *
> > > * @return The new AVEncryptionInfo structure, or NULL on error.
> > > */
> >
> > How is this related to adding a test ?
> >
>
> I guess it's unrelated, created a separate patch for it.
>
> >
> >
> > > diff --git a/libavutil/tests/.gitignore b/libavutil/tests/.gitignore
> > > index 71f75a8ee9..9d90827954 100644
> > > --- a/libavutil/tests/.gitignore
> > > +++ b/libavutil/tests/.gitignore
> > > @@ -17,6 +17,7 @@
> > > /dict
> > > /display
> > > /error
> > > +/encryption_info
> > > /eval
> > > /fifo
> > > /file
> >
> > > @@ -24,6 +25,7 @@
> > > /hmac
> > > /hwdevice
> > > /imgutils
> > > +/integer
> > > /lfg
> > > /lls
> > > /log
> >
> > this also looks unrelated
>
> Same.
>
> >
> >
> > [...]
> > --
> > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > Opposition brings concord. Out of discord comes the fairest harmony.
> > -- Heraclitus
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel> libavutil/Makefile | 1 > libavutil/tests/.gitignore | 1 > libavutil/tests/encryption_info.c | 176 > ++++++++++++++++++++++++++++++++++++++ > tests/fate/libavutil.mak | 4 > tests/ref/fate/encryption-info | 1 > 5 files changed, 182 insertions(+), 1 deletion(-) > 11d60eb571de4510ecbd313cacfaff2e6d89b16e > 0001-libavutil-encryption_info-Add-unit-tests-v2.patch > From c97e44904020944e469faec18b9c279cb6d89b46 Mon Sep 17 00:00:00 2001 > From: Jacob Trimble <modma...@google.com> > Date: Fri, 1 Jun 2018 11:38:05 -0700 > Subject: [PATCH] libavutil/encryption_info: Add unit tests. > > Signed-off-by: Jacob Trimble <modma...@google.com> > --- > libavutil/Makefile | 1 + > libavutil/tests/.gitignore | 1 + > libavutil/tests/encryption_info.c | 176 ++++++++++++++++++++++++++++++ > tests/fate/libavutil.mak | 4 + > tests/ref/fate/encryption-info | 0 > 5 files changed, 182 insertions(+) > create mode 100644 libavutil/tests/encryption_info.c > create mode 100644 tests/ref/fate/encryption-info will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
