2018-06-13 16:57 GMT+02:00, Timo Teras <timo.te...@iki.fi>: > On Tue, 12 Jun 2018 23:09:47 +0200 > Michael Niedermayer <mich...@niedermayer.cc> wrote: > >> On Mon, Jun 04, 2018 at 05:36:19PM +0300, Timo Teräs wrote: >> > For chapter images, the mov demux produces streams with disposition >> > set to attached_pic+timed_thumbnails. This patch fixes to properly >> > recognize streams that should be encoded as cover image (ones with >> > only and only attached_pic disposition set). >> > >> > Signed-off-by: Timo Teräs <timo.te...@iki.fi> >> > --- >> > > ffmpeg should act close to what a inteligent user expects. >> > > For example a simple ffmpeg -i inputfile outputfile >> > > should produce a outputfile that results in similar presentation >> > > as the input when played. >> > >... >> > > It may be good to minimize the amount of exceptions for how >> > > streams are handled. >> > >> > Agree. My question was more about the details how the disposition >> > flags should be handled, because there seems to be no accurate >> > documentation. Apparently the logic is to handle based on what >> > demuxers produce. >> > >> > This patch addresses how the cover image is detected, and should >> > restore earlier behaviour on copying files where demuxer supports >> > more features than current muxer. >> > >> > This applies on top of the "[v2] avformat/movenc: properly handle >> > cover image codecs" patch. I can rebase the order if wanted, but >> > it'll require little work. >> > >> > Hopefully just the above mentioned patch, and this one could be >> > applied in the order. >> >> will apply the 2 patches >> >> adding a fate test may make sense, the patches didnt change any so >> its not tested > > Thanks! Please cherry pick to 4.0-stable too.
Doesn't this change behaviour? Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
