On Sun, 27 May 2018 09:46:46 +0530 Gyan Doshi <gyando...@gmail.com> wrote:
> I was talking about the vertical margins appled to the 'code' element. That's ugly too. I removed the margin for the code element. > From 60ed76348e70f1b0a25eadde8d886d47be3fca69 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi <ffm...@gyani.pro> > Date: Thu, 24 May 2018 19:11:00 +0530 > Subject: [PATCH v2] doc/ffmpeg - rewrite Stream Selection chapter The subject nit still exists. doc/ffmpeg: rewrite Stream Selection chapter > Flesh out with details and examples to show quirks and limitations. > --- > doc/ffmpeg.texi | 187 > +++++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 177 insertions(+), 10 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index 88dbdeb95a..803490ce7b 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi [...] > +It will select that stream based upon the following criteria: > +@* > +@*for video, it is the stream with the highest resolution, > +@*for audio, it is the stream with the most channels, > +@*for subtitles, it is the first subtitle stream found but there's a caveat. > +The output format's default subtitle encoder may be text-based or > image-based, and only a > +subtitle stream of the same type can be chosen. Using an itemized list here will look better in my opinion. @itemize @item for video, it is the stream with the highest resolution, @item ... @end itemize [...] > +@subsubheading Example: automatic stream selection The subsubheadings did not render in the HTML for me, but they did in man. I didn't investigate why. [...] > +@subsubheading Example: unlabeled filtergraph outputs Trailing whitespace. I'm not convinced a verbose, tutorial-style set of examples belongs here. I tend to put such things in the wiki, but if you think otherwise that's fine. That's all of my comments. Everything else LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel