On Fri, Apr 27, 2018 at 02:36:05AM +0200, Michael Niedermayer wrote: > On Fri, Apr 27, 2018 at 12:08:16AM +0100, Josh de Kock wrote: > > The postproc library is only used in a single filter, so should be moved > > into the filter itself if the filter was to stay, but the filter has all of > > its internal filters now in lavfi itself. (Also it's a bit weird to have a > > separate library of filters which is used in a filter in the filter > > library). > > --- > > configure | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > That patch is a bit surprising. > What prompted you to write this ? > > Also, dont you think that before suggesting to deprecate a lib it would make > sense to talk with the author and maintainer of the library in question ? > > Either way, the first question to ask would be > "why was/is it a seperate library" > I think, you do not know, > And you should understand why things are as they are before suggesting to > deprecate, move or otherwise change them
Elaborating on this a bit The first step is to understand the current state of things, why is libpostproc where it is. (it seems noone asked the maintainer / author) after its understood, next is to discuss whats the best thing for the project Some discussion occured on IRC but people neither understood why its in a seperate lib currently nor where anyone who maintains or who wrote it involved in this discussion, making this discussion a bit headless and blind I also think IRC is not ideal for this discussion as only a small subset of people will be there when something is discussed ... Once a consensus is reached what is best to do, that should then be implemented. We have not reached this point nor has anything that was suggested been implemented. The last step then is to deprecate any previous places that are no longer relevant. So this patch is premature, other steps have to be done first Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
