Now it should be fine. Second patch has been fixed. On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник <dan.chered...@gmail.com> wrote:
> Hi. > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind > during patch preparation, it was ok. > I will fix it, and send updated patch. > > Thank you! > > On Sun, Mar 25, 2018 at 5:57 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Sun, Mar 25, 2018 at 01:55:42PM +0300, Даниил Чередник wrote: >> [...] >> >> > libavcodec/dcaenc.c | 369 ++++++++++++++++++++---------- >> -------------------- >> > libavcodec/psymodel.c | 1 >> > tests/fate/acodec.mak | 4 >> > 3 files changed, 156 insertions(+), 218 deletions(-) >> > fd146632a7f29530a59d35abd63149c81b4dfcc6 >> 0002-avcodec-dcaenc-Use-aac-psychoacoustic-model-for-DCA-.patch >> > From 99d937a0828bbd60aef52d7979c75f8c21989145 Mon Sep 17 00:00:00 2001 >> > From: Daniil Cherednik <dan.chered...@gmail.com> >> > Date: Sun, 4 Mar 2018 13:14:17 +0000 >> > Subject: [PATCH 2/2] avcodec/dcaenc: Use aac psychoacoustic model for >> DCA >> > encoder >> > >> > There are several reasons to replace dca psychoacoustic to common model: >> > - dca psychoacoustic has some quality problems especially at high >> frequency bands >> > - unclear implementation >> > - aac implementation allows to use tonality measurement for future >> improvements >> > - a bit faster >> >> This breaks >> make -j12 fate-acodec-dca >> (segfaults) >> >> tell me if you can reproduce? If not ill rebuild with debug symbols and >> get a >> backtrace >> >> [...] >> -- >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >> >> If you drop bombs on a foreign country and kill a hundred thousand >> innocent people, expect your government to call the consequence >> "unprovoked inhuman terrorist attacks" and use it to justify dropping >> more bombs and killing more people. The technology changed, the idea is >> old. >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> > > > -- > Daniil Cherednik > -- Daniil Cherednik
0001-avcodec-dcaenc-Use-planar-float-frame-format.patch
Description: Binary data
0002-avcodec-dcaenc-Use-aac-psychoacoustic-model-for-DCA-.patch
Description: Binary data
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
