On 3/26/2018 7:41 AM, Alexander Kravchenko wrote:
> Hello,
> I have fixed issues listed in previous patch.
>
>
>> Say what the change is in the title. Something like "amfenc: Retain a
>> reference to D3D11 frames used as input during the encoding
>> process", maybe?
> Sure, but I am preparing next patch adding DX9 support, so probably better to
> write D3D instead D3D11
>
>>
>> How many frames can end up queued inside the encoder here?
> 16
>
>>
>> Is there always an exact 1->1 correspondence between input frames and output
>> packets? That is, is it guaranteed that no frames are
>> ever dropped, even in the low-latency modes?
> yes
>
>> Put the * in the right place - it's part of the declarator, not the
>> declaration-specifiers.
>> "if (", and in all places below too.
> I have fixed these issues in whole file (Hopefully you don’t mind if it put
> to same commit. There aren't many pf them)
Usually no, cosmetic changes on existing code go in their own separate
commits.
Also, if this is fixing the issue described in
https://trac.ffmpeg.org/ticket/6990 then please add a "Fixes ticket
#6990" to the commit message.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
