The code looks good to me. I think the wrapper is fine, because that part of code is not suitable for NEON assembly.
But you can remove the using of `sizeof(uint8_t)` as suggested by Carl. Shengbin Meng > On 19 Mar 2018, at 12:41, Yingming Fan <yingming...@gmail.com> wrote: > > Hi, is there any review about this patch? What’s your option about wrapper we > used in this patch. > > Yingming Fan > >> On 11 Mar 2018, at 8:59 PM, Yingming Fan <yingming...@gmail.com> wrote: >> >> >>> On 11 Mar 2018, at 8:54 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>> >>> 2018-03-08 8:03 GMT+01:00 Yingming Fan <yingming...@gmail.com>: >>>> From: Meng Wang <wangmeng.k...@bytedance.com> >>> >>>> + stride_dst /= sizeof(uint8_t); >>>> + stride_src /= sizeof(uint8_t); >>> >>> FFmpeg requires sizeof(uint8_t) to be 1, please simplify >>> your patch accordingly. >>> >>> Why is the wrapper function needed? >> >> We use wrapper because codes in wrapper no need to be written with assembly, >> C codes more readable. >> >>> >>> Carl Eugen >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
