Thanks, sure will take care next time :) On Fri, 16 Mar 2018, 20:26 Carl Eugen Hoyos, <ceffm...@gmail.com> wrote:
> 2018-03-16 11:27 GMT+01:00, Gagandeep Singh <deepgagan231...@gmail.com>: > > From: Gagandeep Singh <sunsi...@iitk.ac.in> > > Thank you for the important patch! > > The first line of the commit message should not start with "area changed" > but something similar to "lavc/cfhd: " which means you can also remove > "cfhd" from the rest of the first line. > > > description:when the chroma_y_shift was not present, the FFALIGN used to > > round the height was unnecessary for 0 chroma shift in y direction. > > The word description is unnecessary. > Please mention ticket #6675, without it is impossible to ever do a > regression test. > > > --- > > libavcodec/cfhd.c | 6 +++--- > > > libavcodec/tests/codec_desc | Bin 0 -> 189776 bytes > > You should not add the file codec_desc to your commit... > > Thank you, Carl Eugen > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
