On Thu, 15 Mar 2018 18:54:00 +0100
Paul B Mahol <one...@gmail.com> wrote:
[...]
> diff --git a/libavfilter/af_hrtfm.c b/libavfilter/af_hrtfm.c
> new file mode 100644
> index 0000000000..48536edd4b
> --- /dev/null
> +++ b/libavfilter/af_hrtfm.c
[...]
> +static const AVOption hrtfm_options[] = {
> + { "hradius", "set head radius", OFFSET(hradius), AV_OPT_TYPE_FLOAT,
> {.dbl=0.0891},0.01,0.2, .flags = FLAGS },
I'd like to see more descriptive option names with the shorter name left as
an alias if desired.
{ "head_radius", "set head radius", OFFSET(head_radius), AV_OPT_TYPE_FLOAT,
{.dbl=0.0891},0.01,0.2, .flags = FLAGS },
{ "hradius", "set head radius", OFFSET(head_radius), AV_OPT_TYPE_FLOAT,
{.dbl=0.0891},0.01,0.2, .flags = FLAGS },
> + { "sspeed", "set sound speed", OFFSET(sspeed), AV_OPT_TYPE_FLOAT,
> {.dbl=334}, 300, 400, .flags = FLAGS },
Same here. sound_speed
Missing docs, and also please provide an example in the docs. Many of
our filters are missing examples.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
