Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: provide detail error message if parameters invalid

[Li, Zhong]

> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Moritz Barsnick
> Sent: Tuesday, March 13, 2018 6:13 PM
> To: FFmpeg development discussions and patches
> <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: provide detail error
> message if parameters invalid
> 
> On Fri, Mar 02, 2018 at 11:24:10 +0800, Zhong Li wrote:
> >      ret = MFXVideoENCODE_Query(q->session, &q->param,
> &param_out);
> > -    if (ret < 0 ||
> > -        param_out.mfx.RateControlMethod !=
> q->param.mfx.RateControlMethod)
> 
> This original code gave the impression that a mismatch of
> RateControlMethod was not reported by MFXVideoENCODE_Query(), and
> therefore checked separately. You are not doing that anymore.
That is an intentional behavior. If current bit rate control mode is not 
supported. MFXVideoENCODE_Query() should return an invalid value as MSDK 
documentation. 
> 
> > +        if (UNMATCH(FrameInfo.FrameRateExtN) ||
> > + UNMATCH(FrameInfo.FrameRateExtN))
> 
> Typo? (Both macro arguments are identical.)
Yes, it is should be "FrameInfo.FrameRateExtD", I have a patch to fix it and 
will send soon.
> 
> Moritz

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel