On Fri, Mar 02, 2018 at 11:59:33PM +0100, Marton Balint wrote: > > On Fri, 2 Mar 2018, Hendrik Leppkes wrote: > > > On Fri, Mar 2, 2018 at 11:19 PM, Aurelien Jacobs <au...@gnuage.org> wrote: > > > On Fri, Mar 02, 2018 at 10:02:58PM +0000, Rostislav Pehlivanov wrote: > > > > On 2 March 2018 at 21:57, Aurelien Jacobs <au...@gnuage.org> wrote: > > > > > > > > > On Fri, Mar 02, 2018 at 09:39:48PM +0100, Michael Niedermayer wrote: > > > > > > On Thu, Mar 01, 2018 at 09:41:20PM +0100, Aurelien Jacobs wrote: > > > > > > > supported suffixes are: > > > > > > > - s: seconds (default when no suffix specified) > > > > > > > - m or ms: milliseconds > > > > > > > - u or us: microseconds > > I don't see much benefit in accepting the SI prefixes without actual > unit,
Maybe for conciseness... And because the unit is already implied by the option name. When setting a time the unit is second, when setting a bitrate the unit is bit per seconds so specifying the unit after the prefix might be considered redundant. Not that I personnaly really care. I wouldn't mind writting 128kb/s rather than 128k. > the purpose of this whoule patch is intuitive and readable command line, and > an SI prefix alone, without a unit is not intuitive. So I'd drop the > SI-prefix-only variants. I mostly agree, but I allowed the use of SI prefix alone for consistency with other options (bitrate for example). I would suggest that all examples in documentations or tutorials should use full SI prefix + unit for improved readability. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
