On 3/1/18, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Wed, Feb 28, 2018 at 10:14:15PM +0200, Ivan Kalvachev wrote: >> Replace two bit handling loops and internal conditional branch >> with simple formula using few logical operations. >> >> The old function would generate wrong output >> if the input does not fit into 15 bits. >> >> Fix this by using 64 bit math and put_bits64(). >> This case should be quite rare, since the bug >> has not asserted itself. >> >> --- >> It's attempt for speed optimization, but in the >> process it turned out it needs also bugfixing. >> >> I only tested the old case of the code, >> to confirm i've implemented the correct function. >> >> Haven't done any benchmarks or run fate. > > fate fails: >
Well, the good news is that it compiles and doesn't crash. The change of generated files is expected. The old code would write up to 63 bits with regular put_bits() that is limited to 31 bits. Are av_assert2() enabled during fate runs? (That's how put_bits() checks for bit length.) I'd like to know if my code is correct/incorrect before attempting to changing fate checksums. Best Regards _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
