> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Hendrik Leppkes > Sent: Friday, January 19, 2018 6:10 PM > To: FFmpeg development discussions and patches > <ffmpeg-devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: Initialize coded_width/height > > On Fri, Jan 19, 2018 at 6:05 AM, Zhong Li <zhong...@intel.com> wrote: > > coded_width/height are unnitialized and will be overwritten by > > dec_ctx->width/height in avcodec_open2() > > > > This fixes tiket #6958. > > > > Signed-off-by: Zhong Li <zhong...@intel.com> > > --- > > fftools/ffprobe.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index > > 0e7a771..233760d 100644 > > --- a/fftools/ffprobe.c > > +++ b/fftools/ffprobe.c > > @@ -2512,10 +2512,12 @@ static int show_stream(WriterContext *w, > AVFormatContext *fmt_ctx, int stream_id > > case AVMEDIA_TYPE_VIDEO: > > print_int("width", par->width); > > print_int("height", par->height); > > +#if FF_API_LAVF_AVCTX > > if (dec_ctx) { > > print_int("coded_width", dec_ctx->coded_width); > > print_int("coded_height", dec_ctx->coded_height); > > } > > +#endif > > print_int("has_b_frames", par->video_delay); > > sar = av_guess_sample_aspect_ratio(fmt_ctx, stream, NULL); > > if (sar.den) { > > @@ -2912,6 +2914,10 @@ static int open_input_file(InputFile *ifile, > > const char *filename) > > > > ist->dec_ctx->pkt_timebase = stream->time_base; > > ist->dec_ctx->framerate = stream->avg_frame_rate; > > +#if FF_API_LAVF_AVCTX > > + ist->dec_ctx->coded_width = > stream->codec->coded_width; > > + ist->dec_ctx->coded_height = > stream->codec->coded_height; > > +#endif > > > > if (avcodec_open2(ist->dec_ctx, codec, &opts) < 0) { > > av_log(NULL, AV_LOG_WARNING, "Could not open > codec > > for input stream %d\n", > > Lets not write new code based on deprecated API. > > - Hendrik
Refer the discussion on https://patchwork.ffmpeg.org/patch/7342/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
