2018-01-19 17:09 GMT+01:00 James Almer <jamr...@gmail.com>: > On 1/19/2018 8:19 AM, Carl Eugen Hoyos wrote: >> 2018-01-19 4:51 GMT+01:00 James Almer <jamr...@gmail.com>: >>> Improves remuxing support when vp9 decoder is not compiled in. >> >>> +static int read_colorspace_details(AVCodecParserContext *ctx, >>> AVCodecContext *avctx, >>> + GetBitContext *gb) >> >> Isn't this a duplicate of an existing, non-trivial function? >> >> Carl Eugen > > Yes, but just like how h264/hevc have duplicate NAL parsing code all > across the codebase, it's different enough that making it shared would > be too complex/dirty to be worth the hassle.
I wish this argument would count more often. Thank you, Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel