On Tue, Dec 26, 2017 at 04:06:49PM +0800, mi...@brew.sh wrote:
> From: Maxim Poliakovski <maximumspat...@googlemail.com>
> 
> Changes by Misty De Meo <mistyde...@gmail.com>:
> 
> atrac3plus_parser: remove return statements for invalid data
> 
> atrac3plus_parser: use libavcodec's oma
> 
> Signed-off-by: Misty De Meo <mistyde...@gmail.com>
> ---
>  libavcodec/Makefile            |   1 +
>  libavcodec/allcodecs.c         |   1 +
>  libavcodec/atrac3plus_parser.c | 150 
> +++++++++++++++++++++++++++++++++++++++++
>  libavformat/mpeg.c             |  27 +++++++-
>  4 files changed, 178 insertions(+), 1 deletion(-)
>  create mode 100644 libavcodec/atrac3plus_parser.c

This breaks playback of atrac3p (atrac3p\ phase\ inv\ 2.at3)

Ive not investigated, but i doubt very much that simply removing the
error returns will work. Every single error path must be handled
appropriately and you should ensure that its all correct.
Not loosing or corrupting data on any error path and not doing
anything else bad or undefined ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to