On Mon, Dec 11, 2017 at 11:43:30AM +0100, wm4 wrote: > On Fri, 8 Dec 2017 18:51:52 +0100 > Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > > 2017-12-08 18:45 GMT+01:00 Tiejun.Peng <tiejun.p...@foxmail.com>: > > > i agree with you. too much experience value in condition of Judgement > > > like this: > > > "else if(max_frames>=4 && max_frames >= p->buf_size/10000)". > > > why it is the value ? it is hard to known. > > > maybe the work of cleaned up need a few days, so i just repair of the > > > probe. > > > > Please be careful: > > As you already know, this probe function is the result of many > > user reports, many tests and turning many knobs. You cannot > > "repair" it (easily). > > > > If you know of any false positives of the current probe function, > > please report them! > > It plays ELF files as mp3. > > You've been ignoring this issue, though. > > This probe function is really pretty bad.
The probe code determines the most likely format from the set of supported formats. We do not support playing excutable files (that makes no sense), thus these do not get detected. Is there a usecase where detecting not just the most likely multimedia format but detecting that a file is not any multimedia format makes sense ? Also if a format is detected with a low score the user is informed about this via "Format %s detected only with low score of %d," [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
