On Thu, 2017-12-07 at 14:45 -0800, Mark Reid wrote:
> On Dec 7, 2017 7:45 AM, "Tomas Härdin" <tjop...@acc.umu.se> wrote:
>
> On 2017-12-05 05:46, Mark Reid wrote:
>
> > ---
> > libavformat/mxf.h | 1 +
> > libavformat/mxfenc.c | 42 +++++++++++++++++++++++++++++++++++--
> > -----
> > 2 files changed, 36 insertions(+), 7 deletions(-)
> >
> >
> > @@ -1476,6 +1495,15 @@ static int
> > mxf_write_header_metadata_sets(AVFormatContext
> > *s)
> > }
> > }
> > + entry = av_dict_get(s->metadata, "reel_name", NULL, 0);
> > + if (entry) {
> > + packages[2].name = entry->value;
> > + packages[2].type = SourcePackage;
> > + packages[2].instance = 2;
> > + packages[1].ref = &packages[2];
> > + package_count = 3;
> > + }
> >
>
> I guess we can have it check track metadata later if we feel like it.
> Did a
> patch moving reel_name into AVFormatContext make it into mxfdec yet?
> mxfenc's output surviving a roundtrip through mxfdec + mxfenc might
> be
> desirable:
>
> ffmpeg -i somefile_with_reel_name.mkv output.mxf
> ffmpeg -i output.mxf -vcodec copy -acodec copy remuxed.mxf
>
> Ideally remuxed.mxf is identical to output.mxf
>
> /Tomas
>
>
> Yes I agree that such behaviour is desirable.
> I haven't taken a look at mxfdec yet. Looking in steams for reel_name
> might
> be necessary, as I believe that's where mov,MP4 store it. But I was
> trying
> to keep it simple at first and addressed this specific issue a future
> patch.Fair enough. I guess we can commit this patch series then. Michael? /Tomas
signature.asc
Description: This is a digitally signed message part
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
